openAgent

1/**
2 * Regression test for the same bug class as #26574 (sibling of #26566 and
3 * #26553). The Desktop app calls GET /session/<id>/diff; before #26574
4 * the response was Schema-encoded against `Snapshot.FileDiff` with
5 * `patch: Schema.String` (required), so any session whose stored
6 * `summary_diffs` had a row without `patch` returned HTTP 400 and the
7 * session never loaded. Legacy session-level diffs are no longer surfaced,
8 * but the endpoint remains compatible and must still return successfully.
9 *
10 * This test inserts a session row with a missing-patch diff entry and
11 * asserts that GET /session/<id>/diff returns 200 with empty data.
12 */
13import { afterEach, describe, expect } from "bun:test"
14import { LayerNode } from "@opencode-ai/core/effect/layer-node"
15import { Effect, Layer } from "effect"
16import { SessionPaths } from "@/server/routes/instance/httpapi/groups/session"
17import { Session } from "@/session/session"
18import { Storage } from "@/storage/storage"
19import { SessionV1 } from "@opencode-ai/core/v1/session"
20import { MessageID } from "@/session/schema"
21import { ProviderV2 } from "@opencode-ai/core/provider"
22import { ModelV2 } from "@opencode-ai/core/model"
23import { resetDatabase } from "../fixture/db"
24import { disposeAllInstances, TestInstance } from "../fixture/fixture"
25import { testEffect } from "../lib/effect"
26import { httpApiLayer, requestInDirectory } from "./httpapi-layer"
27 
28const it = testEffect(Layer.mergeAll(LayerNode.compile(LayerNode.group([Session.node, Storage.node])), httpApiLayer))
29 
30afterEach(async () => {
31  await disposeAllInstances()
32  await resetDatabase()
33})
34 
35function pathFor(template: string, params: Record<string, string>) {
36  return Object.entries(params).reduce((result, [key, value]) => result.replace(`:${key}`, value), template)
37}
38 
39const withSession = (input?: Parameters<Session.Interface["create"]>[0]) =>
40  Effect.acquireRelease(Session.use.create(input), (created) => Session.use.remove(created.id).pipe(Effect.ignore))
41 
42describe("session diff with missing patch (#26574)", () => {
43  it.instance(
44    "GET /session/<id>/diff ignores legacy session-level diff storage",
45    () =>
46      Effect.gen(function* () {
47        const test = yield* TestInstance
48        const session = yield* withSession({ title: "missing-patch" })
49 
50        // Mimic legacy/imported on-disk shape: a diff entry with no
51        // `patch` text. Pre-fix the typed response encoder rejects
52        // this and returns 400.
53        yield* Storage.Service.use((storage) =>
54          storage.write(["session_diff", session.id], [{ file: "legacy.txt", additions: 1, deletions: 0 }]),
55        )
56 
57        const response = yield* requestInDirectory(
58          pathFor(SessionPaths.diff, { sessionID: session.id }),
59          test.directory,
60        )
61 
62        expect(response.status).toBe(200)
63        expect(yield* response.json).toEqual([])
64      }),
65    { git: true, config: { formatter: false, lsp: false } },
66  )
67 
68  it.instance(
69    "GET /session/<id>/diff returns requested turn diffs",
70    () =>
71      Effect.gen(function* () {
72        const test = yield* TestInstance
73        const session = yield* withSession({ title: "turn-diff" })
74        const messageID = MessageID.ascending()
75        yield* Session.use.updateMessage({
76          id: messageID,
77          sessionID: session.id,
78          role: "user",
79          time: { created: Date.now() },
80          agent: "build",
81          model: { providerID: ProviderV2.ID.make("test"), modelID: ModelV2.ID.make("model") },
82          summary: {
83            diffs: [{ file: "turn.ts", additions: 1, deletions: 0, status: "modified" }],
84          },
85        } satisfies SessionV1.User)
86 
87        const response = yield* requestInDirectory(
88          `${pathFor(SessionPaths.diff, { sessionID: session.id })}?messageID=${messageID}`,
89          test.directory,
90        )
91 
92        expect(response.status).toBe(200)
93        expect(yield* response.json).toEqual([{ file: "turn.ts", additions: 1, deletions: 0, status: "modified" }])
94      }),
95    { git: true, config: { formatter: false, lsp: false } },
96  )
97})
98